-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/transport server external name #3041
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3041 +/- ##
==========================================
- Coverage 52.31% 52.28% -0.03%
==========================================
Files 58 58
Lines 15995 16028 +33
==========================================
+ Hits 8368 8381 +13
- Misses 7350 7369 +19
- Partials 277 278 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a README for the new externalname-services
example files?
It's WIP (work in progress) |
examples/custom-resources/externalname-services/transport-server/README.md
Outdated
Show resolved
Hide resolved
name: externalname-service | ||
spec: | ||
type: ExternalName | ||
externalName: external-backend-svc.external-ns.svc.cluster.local |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example isn't working - the externalName entry needs to be changed to map to the name for the service defined in secure-app-external.yaml
externalName: external-backend-svc.external-ns.svc.cluster.local | |
externalName: secure-app-external-backend-svc.external-ns.svc.cluster.local |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry - I realise now that updating this is called out in the README. Again I think this is confusing and we are better off duplicating the files with the correct service name in each (one for TS and one for VS); or just having the same service name for both of the external name services
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated and moved all yaml files required for this example to transport server folder.
Proposed changes
Initial support for Transport Server external name including examples.
Checklist
Before creating a PR, run through this checklist and mark each as complete.