Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/transport server external name #3041

Merged
merged 27 commits into from
Sep 26, 2022
Merged

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Sep 15, 2022

Proposed changes

Initial support for Transport Server external name including examples.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Sep 15, 2022
@jjngx jjngx requested review from haywoodsh and vepatel September 15, 2022 15:18
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2022

Codecov Report

Merging #3041 (0186b91) into main (23be85f) will decrease coverage by 0.02%.
The diff coverage is 23.80%.

@@            Coverage Diff             @@
##             main    #3041      +/-   ##
==========================================
- Coverage   52.31%   52.28%   -0.03%     
==========================================
  Files          58       58              
  Lines       15995    16028      +33     
==========================================
+ Hits         8368     8381      +13     
- Misses       7350     7369      +19     
- Partials      277      278       +1     
Impacted Files Coverage Δ
cmd/nginx-ingress/flags.go 34.42% <ø> (ø)
cmd/nginx-ingress/main.go 0.00% <0.00%> (ø)
internal/configs/config_params.go 76.74% <ø> (ø)
internal/configs/configurator.go 37.06% <0.00%> (-0.32%) ⬇️
internal/configs/version1/config.go 0.00% <ø> (ø)
internal/configs/version2/http.go 0.00% <ø> (ø)
internal/k8s/controller.go 11.07% <0.00%> (-0.05%) ⬇️
internal/configs/configmaps.go 20.37% <100.00%> (+0.16%) ⬆️
internal/configs/transportserver.go 97.48% <100.00%> (+3.70%) ⬆️
internal/configs/virtualserver.go 95.22% <100.00%> (+<0.01%) ⬆️
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jjngx jjngx marked this pull request as ready for review September 16, 2022 11:59
@jjngx jjngx requested review from a team, lucacome and ciarams87 September 16, 2022 12:00
@github-actions github-actions bot added the tests Pull requests that update tests label Sep 16, 2022
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Sep 19, 2022
internal/configs/configurator.go Show resolved Hide resolved
internal/configs/configurator.go Show resolved Hide resolved
internal/configs/configurator.go Show resolved Hide resolved
internal/configs/configurator.go Show resolved Hide resolved
internal/configs/configurator.go Show resolved Hide resolved
Copy link
Contributor

@shaun-nx shaun-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a README for the new externalname-services example files?

@jjngx
Copy link
Contributor Author

jjngx commented Sep 21, 2022

Can we add a README for the new externalname-services example files?

It's WIP (work in progress)

name: externalname-service
spec:
type: ExternalName
externalName: external-backend-svc.external-ns.svc.cluster.local
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example isn't working - the externalName entry needs to be changed to map to the name for the service defined in secure-app-external.yaml

Suggested change
externalName: external-backend-svc.external-ns.svc.cluster.local
externalName: secure-app-external-backend-svc.external-ns.svc.cluster.local

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - I realise now that updating this is called out in the README. Again I think this is confusing and we are better off duplicating the files with the correct service name in each (one for TS and one for VS); or just having the same service name for both of the external name services

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated and moved all yaml files required for this example to transport server folder.

@jjngx jjngx merged commit badb489 into main Sep 26, 2022
@jjngx jjngx deleted the feat/transport-server-external-name branch September 26, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements tests Pull requests that update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants