Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding automountServiceAccountToken to helm chart #3031

Merged
merged 7 commits into from
Sep 15, 2022
Merged

Conversation

jasonwilliams14
Copy link
Contributor

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • [ x] I have read the CONTRIBUTING doc
  • [ x] I have added tests that prove my fix is effective or that my feature works
  • [ x] I have checked that all unit tests pass after adding my changes
  • [ x] I have updated necessary documentation
  • I have rebased my branch onto main
  • [ x] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jasonwilliams14 jasonwilliams14 added enhancement Pull requests for new features/feature enhancements documentation Pull requests/issues for documentation labels Sep 10, 2022
deployments/helm-chart/values.yaml Outdated Show resolved Hide resolved
docs/content/installation/installation-with-helm.md Outdated Show resolved Hide resolved
deployments/helm-chart/README.md Outdated Show resolved Hide resolved
@lucacome
Copy link
Member

Not sure if my suggestions for the descriptions make sense, calling in @nginxinc/nginx-docs 😄

@lucacome lucacome requested a review from a team September 10, 2022 00:27
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2022

Codecov Report

Merging #3031 (6746a05) into main (f03f906) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 6746a05 differs from pull request most recent head cfa058d. Consider uploading reports for the commit cfa058d to get more accurate results

@@            Coverage Diff             @@
##             main    #3031      +/-   ##
==========================================
- Coverage   52.32%   52.29%   -0.04%     
==========================================
  Files          58       58              
  Lines       15995    15995              
==========================================
- Hits         8370     8364       -6     
- Misses       7348     7352       +4     
- Partials      277      279       +2     
Impacted Files Coverage Δ
...ternal/k8s/appprotect/app_protect_configuration.go 86.16% <0.00%> (-0.58%) ⬇️
internal/k8s/configuration.go 95.39% <0.00%> (-0.37%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jasonwilliams14
Copy link
Contributor Author

Closed duplicate PR and added files for the manifest files as needed.

@github-actions github-actions bot removed the documentation Pull requests/issues for documentation label Sep 14, 2022
@ciarams87 ciarams87 merged commit c021995 into main Sep 15, 2022
@ciarams87 ciarams87 deleted the feat/helm-automount branch September 15, 2022 22:02
lucacome pushed a commit that referenced this pull request Sep 16, 2022
adding automountServiceAccountToken to helm chart (#3031)

Co-authored-by: Jason Williams <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants