-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated kubernetes.io/ingress.class from examples #3029
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3029 +/- ##
==========================================
+ Coverage 52.29% 52.31% +0.01%
==========================================
Files 58 58
Lines 16006 15995 -11
==========================================
- Hits 8371 8368 -3
+ Misses 7356 7350 -6
+ Partials 279 277 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
92612e1
to
9c7ae7e
Compare
@lucacome can we do it for docs only first? some tests are breaking because of this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the first two files really part of this PR? If not can they go into their own PR?
9c7ae7e
to
9e50467
Compare
Hi Luca are you going to remove the non-relevant files (as discussed last week)? |
9163d00
to
e5f4dbb
Compare
Replaces
kubernetes.io/ingress.class
withingressClassName
.Opening it as a draft as I'm not sure if we need to add something to the examples to call out the need to deploy the ingressClass. It's already called out in the https://docs.nginx.com/nginx-ingress-controller/installation/installation-with-manifests/ and we deploy it automatically with
helm