Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated kubernetes.io/ingress.class from examples #3029

Merged
merged 2 commits into from
Sep 23, 2022

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Sep 9, 2022

Replaces kubernetes.io/ingress.class with ingressClassName.

Opening it as a draft as I'm not sure if we need to add something to the examples to call out the need to deploy the ingressClass. It's already called out in the https://docs.nginx.com/nginx-ingress-controller/installation/installation-with-manifests/ and we deploy it automatically with helm

@lucacome lucacome requested review from a team, haywoodsh, jjngx and shaun-nx September 9, 2022 18:31
@lucacome lucacome self-assigned this Sep 9, 2022
@github-actions github-actions bot added chore Pull requests for routine tasks documentation Pull requests/issues for documentation tests Pull requests that update tests labels Sep 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2022

Codecov Report

Merging #3029 (9163d00) into main (d78f57b) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 9163d00 differs from pull request most recent head e5f4dbb. Consider uploading reports for the commit e5f4dbb to get more accurate results

@@            Coverage Diff             @@
##             main    #3029      +/-   ##
==========================================
+ Coverage   52.29%   52.31%   +0.01%     
==========================================
  Files          58       58              
  Lines       16006    15995      -11     
==========================================
- Hits         8371     8368       -3     
+ Misses       7356     7350       -6     
+ Partials      279      277       -2     
Impacted Files Coverage Δ
...ternal/k8s/appprotect/app_protect_configuration.go 86.16% <0.00%> (-0.58%) ⬇️
internal/configs/configmaps.go 20.21% <0.00%> (-0.17%) ⬇️
internal/configs/transportserver.go 93.78% <0.00%> (-0.04%) ⬇️
internal/configs/virtualserver.go 95.22% <0.00%> (-0.01%) ⬇️
cmd/nginx-ingress/main.go 0.00% <0.00%> (ø)
cmd/nginx-ingress/flags.go 34.42% <0.00%> (ø)
internal/configs/config_params.go 76.74% <0.00%> (ø)
internal/configs/version2/http.go 0.00% <0.00%> (ø)
internal/configs/version1/config.go 0.00% <0.00%> (ø)
internal/k8s/controller.go 11.11% <0.00%> (+0.01%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lucacome lucacome force-pushed the chore/ingress-class branch from 92612e1 to 9c7ae7e Compare September 9, 2022 18:44
@vepatel
Copy link
Contributor

vepatel commented Sep 13, 2022

@lucacome can we do it for docs only first? some tests are breaking because of this change.

Copy link
Contributor

@tomasohaodha tomasohaodha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the first two files really part of this PR? If not can they go into their own PR?

@tomasohaodha
Copy link
Contributor

Hi Luca are you going to remove the non-relevant files (as discussed last week)?

@github-actions github-actions bot removed the tests Pull requests that update tests label Sep 22, 2022
@lucacome lucacome changed the title Remove deprecated kubernetes.io/ingress.class from examples and tests Remove deprecated kubernetes.io/ingress.class from examples Sep 22, 2022
@lucacome lucacome marked this pull request as ready for review September 22, 2022 17:02
@lucacome lucacome merged commit 17aad37 into main Sep 23, 2022
@lucacome lucacome deleted the chore/ingress-class branch September 23, 2022 16:46
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants