Improve NAP DoS tests #2996
Merged
Improve NAP DoS tests #2996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2996 +/- ##
==========================================
- Coverage 52.31% 52.29% -0.03%
==========================================
Files 58 58
Lines 15965 15995 +30
==========================================
+ Hits 8352 8364 +12
- Misses 7335 7352 +17
- Partials 278 279 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
vepatel
reviewed
Sep 8, 2022
| @@ -206,6 +215,12 @@ def test_dos_vs_logs( | |||
| print(f"log_loc: {log_loc} syslog_pod: {syslog_pod} namespace: {ingress_controller_prerequisites.namespace}") | |||
| log_contents = get_file_contents(kube_apis.v1, log_loc, syslog_pod, ingress_controller_prerequisites.namespace) | |||
|
|
|||
| # print("\n===================== ADMD Logs Start =====================") | |||
There was a problem hiding this comment.
@pasmant can you please remove the commented code if not needed?
There was a problem hiding this comment.
There is any log level in pytest?
vepatel
reviewed
Sep 15, 2022
| @@ -133,6 +141,7 @@ def fin(): | |||
| delete_dos_policy(kube_apis.custom_objects, pol_name, test_namespace) | |||
| delete_dos_logconf(kube_apis.custom_objects, log_name, test_namespace) | |||
| delete_dos_protected(kube_apis.custom_objects, protected_name, test_namespace) | |||
| clean_good_bad_clients() | |||
| # delete_items_from_yaml(kube_apis, src_webapp_yaml, test_namespace) | |||
There was a problem hiding this comment.
@pasmant more commented code here, can you please have a look?
vepatel
approved these changes
Sep 20, 2022
tomasohaodha
approved these changes
Sep 20, 2022
lucacome
reviewed
Sep 20, 2022
| @@ -233,74 +243,6 @@ def test_dos_sec_logs_on( | |||
| assert f'vs_name="{test_namespace}/dos-protected/name"' in log_contents | |||
| assert "bad_actor" in log_contents | |||
|
|
|||
| def test_dos_under_attack_no_learning( | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make dos tests more robust