Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Batch reloads runtime #2986

Merged
merged 5 commits into from
Sep 5, 2022
Merged

chore: Batch reloads runtime #2986

merged 5 commits into from
Sep 5, 2022

Conversation

ciarams87
Copy link
Contributor

@ciarams87 ciarams87 commented Aug 30, 2022 •
edited
Loading

Proposed changes

Extend the start-up batch reload logic to batch NGINX reloads when there is more than one task in the queue during runtime.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ciarams87 ciarams87 force-pushed the batch-reloads-runtime branch 4 times, most recently from ba7d697 to 1e21419 Compare August 31, 2022 08:34
@ciarams87 ciarams87 changed the title Batch reloads runtime chore: Batch reloads runtime Aug 31, 2022
@ciarams87 ciarams87 force-pushed the batch-reloads-runtime branch from 1e21419 to e96ef81 Compare August 31, 2022 09:08
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Aug 31, 2022
@ciarams87 ciarams87 requested review from a team, lucacome, jjngx and shaun-nx August 31, 2022 09:08
@ciarams87 ciarams87 marked this pull request as ready for review August 31, 2022 09:09
@ciarams87 ciarams87 added the chore Pull requests for routine tasks label Sep 2, 2022
@ciarams87 ciarams87 force-pushed the batch-reloads-runtime branch from 07f0ab2 to ede74f8 Compare September 2, 2022 13:26
shaun-nx
shaun-nx approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@shaun-nx shaun-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Left two comments to consider. Nothing functional though.

@ciarams87 ciarams87 merged commit 7c95cd1 into main Sep 5, 2022
@ciarams87 ciarams87 deleted the batch-reloads-runtime branch September 5, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel left review comments

@shaun-nx shaun-nx shaun-nx approved these changes

@jjngx jjngx jjngx approved these changes

@lucacome lucacome Awaiting requested review from lucacome lucacome was automatically assigned from nginxinc/kic

Assignees
No one assigned
Labels
chore Pull requests for routine tasks documentation Pull requests/issues for documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ciarams87 @vepatel @jjngx @shaun-nx