Improve Helm Chart #296
Merged
Improve Helm Chart #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dean-Coakley
added
the
enhancement
pleshakov
suggested changes
Jun 18, 2018
helm-chart/README.md
Outdated
|
|
||
| ## Notes | ||
| * The values-icp.yaml file is used for deploying the Ingress controller on IBM Cloud Private. See the blog post for more details. |
There was a problem hiding this comment.
add a missing link -- https://www.nginx.com/blog/nginx-ingress-controller-ibm-cloud-private/
| protocol: TCP | ||
| name: https | ||
| selector: | ||
| app: {{ .Values.controller.name }} |
| apiVersion: v1 | ||
| kind: Service | ||
| metadata: | ||
| name: {{ .Values.controller.name }} |
There was a problem hiding this comment.
perhaps change it to nginx-ingress ?
Several improvements to Helm Chart necessary for any production environment The Helm Chart now supports: * RBAC * ConfigMap * Replica * NodePort and LoadBalancer Services * Custom IC Args Update Chart files Follow best practices Update Documentation Fix IBM ICP bugs
Dean-Coakley
force-pushed
the
helm-improvements
branch
from
7c77f0f to
adfa0fb
Compare
pleshakov
approved these changes
Jun 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several improvements to Helm Chart necessary for any production
environment
The Helm Chart now supports:
Update Chart files
Follow best practices
Update Documentation
Fix IBM ICP bugs