Add support for wildcard hostname in VirutalServer #2939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
enhancement
shaun-nx
changed the title
added 6 commits
August 18, 2022 10:57
Codecov Report
@@ Coverage Diff @@
## main #2939 +/- ##
==========================================
+ Coverage 52.28% 52.32% +0.03%
==========================================
Files 58 58
Lines 15965 15970 +5
==========================================
+ Hits 8348 8357 +9
+ Misses 7337 7335 -2
+ Partials 280 278 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…s-ingress into feat/wildcardhostname
github-actions
bot
added
the
documentation
ciarams87
reviewed
Aug 24, 2022
| func validateHost(host string, fieldPath *field.Path) field.ErrorList { | ||
| allErrs := field.ErrorList{} | ||
|
|
||
| if host == "" { | ||
| return append(allErrs, field.Required(fieldPath, "")) | ||
| } | ||
|
|
||
| for _, msg := range validation.IsDNS1123Subdomain(host) { | ||
| allErrs = append(allErrs, field.Invalid(fieldPath, host, msg)) | ||
| if !strings.HasPrefix(host, wildcardHost) { |
There was a problem hiding this comment.
We should also validate the wildcard host - we can use validation.IsWildcardDNS1123Subdomain
see here for reference
vepatel
reviewed
Aug 26, 2022
| service.beta.kubernetes.io/aws-load-balancer-backend-protocol: "tcp" | ||
| service.beta.kubernetes.io/aws-load-balancer-proxy-protocol: "*" | ||
| service.beta.kubernetes.io/aws-load-balancer-type: "nlb" | ||
| service.beta.kubernetes.io/aws-load-balancer-nlb-target-type: "ip" |
There was a problem hiding this comment.
minor one but these 2 annotations can be appended to old list instead of replacing them
vepatel
reviewed
Aug 26, 2022
| @@ -51,7 +51,7 @@ spec: | |||
| {{% table %}} | |||
| |Field | Description | Type | Required | | |||
| | ---| ---| ---| --- | | |||
| |``host`` | The host (domain name) of the server. Must be a valid subdomain as defined in RFC 1123, such as ``my-app`` or ``hello.example.com``. Wildcard domains like ``*.example.com`` are not allowed. The ``host`` value needs to be unique among all Ingress and VirtualServer resources. See also [Handling Host and Listener Collisions](/nginx-ingress-controller/configuration/handling-host-and-listener-collisions). | ``string`` | Yes | | |||
| |``host`` | The host (domain name) of the server. Must be a valid subdomain as defined in RFC 1123, such as ``my-app`` or ``hello.example.com``. When using a wildcard domain like ``*.example.com`` the domain must be contained in double quotes. The ``host`` value needs to be unique among all Ingress and VirtualServer resources. See also [Handling Host and Listener Collisions](/nginx-ingress-controller/configuration/handling-host-and-listener-collisions). | ``string`` | Yes | | |||
There was a problem hiding this comment.
The ``host`` value needs to be unique: do we allow two VS resources with same wildcard host? eg. both with *.something.com
There was a problem hiding this comment.
Good point. I'll check if that's possible or not.
There was a problem hiding this comment.
We don't allow two VS resources to be deployed with the same wildcard hostname. Output below is what I got when I tried this:
Spec:
Host: *.example.com
Routes:
Action:
Pass: tea
Path: /tea
Action:
Pass: coffee
Path: /coffee
Tls:
Secret: cafe-secret
Upstreams:
Name: tea
Port: 80
Service: tea-svc
Name: coffee
Port: 80
Service: coffee-svc
Status:
Message: Host is taken by another resource
Reason: Rejected
State: Warning
Events:
Type Reason Age From Message
---- ------ ---- ---- -------
Warning Rejected 13s nginx-ingress-controller Host is taken by another resource
vepatel
approved these changes
Aug 26, 2022
jjngx
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change updates the
VirutalServerCRD to add support for a wildcard hostname.This change also makes updates to ExternalDNS to allow a
DNSEndpointtype to be created when specifying a wildcard hostname in aVirtualServerobject.Checklist
Before creating a PR, run through this checklist and mark each as complete.