Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Remove unnecessary library from tests #2925

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Conversation

ciarams87
Copy link
Contributor

@ciarams87 ciarams87 commented Aug 12, 2022

Proposed changes

This CVE is being flagged against the project: https://www.mend.io/vulnerability-database/CVE-2020-14422. It's potentially a false positive because the library we are importing is actually https://github.com/phihag/ipaddress but we don't need that library anyway so this commit removes it from the requirements. This commit also updates the TransportServer tests to work locally using Kind.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ciarams87 ciarams87 requested review from vepatel, a team, jjngx and shaun-nx August 12, 2022 09:23
@ciarams87 ciarams87 changed the title tests: Remove unnecessary library from testswq tests: Remove unnecessary library from tests Aug 12, 2022
@ciarams87 ciarams87 added the tests Pull requests that update tests label Aug 12, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2925 (2262e36) into main (9996ce6) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2925      +/-   ##
==========================================
- Coverage   53.01%   52.99%   -0.03%     
==========================================
  Files          58       58              
  Lines       15651    15651              
==========================================
- Hits         8298     8294       -4     
- Misses       7076     7078       +2     
- Partials      277      279       +2     
Impacted Files Coverage Δ
internal/k8s/configuration.go 95.39% <0.00%> (-0.37%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ciarams87 ciarams87 merged commit 13e0360 into main Aug 12, 2022
@ciarams87 ciarams87 deleted the update-ipaddress-lib branch August 12, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants