Feature/flag include year #2884
Conversation
…:nginxinc/kubernetes-ingress into feature/replace-glog-with-forked-version
github-actions
bot
added
dependencies
Codecov Report
@@ Coverage Diff @@
## main #2884 +/- ##
==========================================
+ Coverage 53.02% 53.03% +0.01%
==========================================
Files 58 58
Lines 15641 15645 +4
==========================================
+ Hits 8294 8298 +4
- Misses 7068 7070 +2
+ Partials 279 277 -2
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
…netes-ingress into feature/flag-include-year
| @@ -65,6 +65,7 @@ spec: | |||
| - -nginx-plus | |||
| - -nginx-configmaps=$(POD_NAMESPACE)/nginx-config | |||
| - -default-server-tls-secret=$(POD_NAMESPACE)/default-server-secret | |||
| #- -include-year | |||
There was a problem hiding this comment.
can specify the same in deployments/daemon-set/nginx-plus-ingress.yaml as well
There was a problem hiding this comment.
Good catch. I will also add it to the OSS version of the deployments
| @@ -178,6 +178,9 @@ controller: | |||
| ## Enable OIDC policies. | |||
| enableOIDC: false | |||
|
|
|||
| ## Include year in log header. This parameter will be removed in release 2.7 and the year will be included by default. | |||
| includeYear: false | |||
There was a problem hiding this comment.
a corresponding entry in https://github.com/nginxinc/kubernetes-ingress/blob/feature/flag-include-year/docs/content/installation/installation-with-helm.md as controller.includeYear
There was a problem hiding this comment.
Not sure I understand this. None of the values in this file start with controller. why would the includeYear value need to start with that?
There was a problem hiding this comment.
it refers to https://github.com/nginxinc/kubernetes-ingress/blob/feature/flag-include-year/deployments/helm-chart/values.yaml#L1 so when you're installing using helm-chart helm install my-release --set controller.kind=daemonset --set controller.nginxplus=true --set controller.image.repository=nginx-ingress --set controller.image.tag=edge --set controller.includeYear=true ......
Proposed changes
This change introduces a new flag to the ingress controller
-include-yearwhich will add the year to the log header when set. The default value of this flag isfalseDeprecation notice
This flag is planned to be remove from the ingress controller by release 2.7 at which point all logs from the ingress controller will display the year by default.
Checklist
Before creating a PR, run through this checklist and mark each as complete.