NGINX Ingress Controller Configuration guide update #2864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jcahilltorre
approved these changes
Jul 18, 2022
liorm39
suggested changes
Jul 18, 2022
aknot242
suggested changes
Jul 20, 2022
brianehlert
requested changes
Jul 20, 2022
There was a problem hiding this comment.
The header "## Enable App Protect for an Ingress Resource" leaves the reader with the impression that App Protect can only be configured using the Ingress resource.
This impression needs to be altered and the reader should walk away with the understanding that they can use either the Custom Resources (VirtualServer, VirtualServerRoute) or the Ingress resource.
Both should be equally represented or the preference should lean to the Custom Resources.
aknot242
suggested changes
Jul 20, 2022
brianehlert
reviewed
Jul 20, 2022
brianehlert
reviewed
Jul 20, 2022
liorm39
suggested changes
Jul 21, 2022
liorm39
suggested changes
Jul 21, 2022
liorm39
approved these changes
Jul 21, 2022
aknot242
reviewed
Jul 21, 2022
brianehlert
reviewed
Jul 21, 2022
|
@brianehlert @aknot242 are you happy with the changes or does this PR need more work? |
aknot242
suggested changes
Aug 3, 2022
brianehlert
reviewed
Aug 4, 2022
aknot242
suggested changes
Aug 4, 2022
rranghar
force-pushed
the
Missing_Documentation_for_Use_Cases_for_NAP_within_NIC
branch
from
1df1e4d to
6669053
Compare
rranghar
changed the title
… of https://github.com/rranghar/kubernetes-ingress into Missing_Documentation_for_Use_Cases_for_NAP_within_NIC
ciarams87
reviewed
Aug 22, 2022
ciarams87
reviewed
Aug 22, 2022
ciarams87
reviewed
Aug 22, 2022
ciarams87
reviewed
Aug 22, 2022
ciarams87
reviewed
Aug 22, 2022
ciarams87
reviewed
Aug 22, 2022
ciarams87
pushed a commit
that referenced
this pull request
Aug 22, 2022
* Missing_Documentation_for_Use_Cases_for_NAP_within_NIC
6 tasks
ciarams87
added a commit
that referenced
this pull request
Aug 22, 2022
* NGINX Ingress Controller Configuration guide update (#2864) * Missing_Documentation_for_Use_Cases_for_NAP_within_NIC * Fix formatting Co-authored-by: rranghar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update the documentation with NAP configuration guidelines and examples.
Checklist
Before creating a PR, run through this checklist and mark each as complete.