-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation for App Protect ingress annotations #2793
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Pull requests/issues for documentation
label
Jun 23, 2022
Codecov Report
@@ Coverage Diff @@
## main #2793 +/- ##
==========================================
+ Coverage 54.03% 54.09% +0.06%
==========================================
Files 53 53
Lines 15009 15023 +14
==========================================
+ Hits 8110 8127 +17
+ Misses 6629 6626 -3
Partials 270 270
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
haywoodsh
changed the title
Appprotect annotations
Validation for App Protect ingress annotations
Jun 23, 2022
ciarams87
reviewed
Jun 23, 2022
docs/content/configuration/ingress-resources/advanced-configuration-with-annotations.md
Outdated
Show resolved
Hide resolved
ciarams87
reviewed
Jun 23, 2022
docs/content/configuration/ingress-resources/advanced-configuration-with-annotations.md
Outdated
Show resolved
Hide resolved
haywoodsh
force-pushed
the
appprotect-annotations
branch
from
June 24, 2022 18:40
1fc3252
to
46764a3
Compare
shaun-nx
approved these changes
Jun 27, 2022
ciarams87
approved these changes
Jun 27, 2022
Co-authored-by: Ciara Stacke <[email protected]>
Co-authored-by: Ciara Stacke <[email protected]>
haywoodsh
force-pushed
the
appprotect-annotations
branch
from
June 27, 2022 19:53
46764a3
to
490e669
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add validation for App Protect ingress annotations
Checklist
Before creating a PR, run through this checklist and mark each as complete.