Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation for App Protect ingress annotations #2793

Merged
merged 7 commits into from
Jun 27, 2022
Merged

Conversation

haywoodsh
Copy link
Contributor

Proposed changes

Add validation for App Protect ingress annotations

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jun 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2022

Codecov Report

Merging #2793 (7afd9c2) into main (59e4dd9) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2793      +/-   ##
==========================================
+ Coverage   54.03%   54.09%   +0.06%     
==========================================
  Files          53       53              
  Lines       15009    15023      +14     
==========================================
+ Hits         8110     8127      +17     
+ Misses       6629     6626       -3     
  Partials      270      270              
Impacted Files Coverage Δ
internal/k8s/controller.go 11.38% <ø> (+0.02%) ⬆️
internal/k8s/validation.go 97.89% <100.00%> (+0.09%) ⬆️
...ternal/k8s/appprotect/app_protect_configuration.go 86.16% <0.00%> (-0.58%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@haywoodsh haywoodsh changed the title Appprotect annotations Validation for App Protect ingress annotations Jun 23, 2022
@haywoodsh haywoodsh marked this pull request as ready for review June 24, 2022 18:30
@haywoodsh haywoodsh force-pushed the appprotect-annotations branch from 1fc3252 to 46764a3 Compare June 24, 2022 18:40
@haywoodsh haywoodsh force-pushed the appprotect-annotations branch from 46764a3 to 490e669 Compare June 27, 2022 19:53
@haywoodsh haywoodsh enabled auto-merge (squash) June 27, 2022 19:55
@haywoodsh haywoodsh merged commit 9b57ba2 into main Jun 27, 2022
@haywoodsh haywoodsh deleted the appprotect-annotations branch June 27, 2022 19:56
@ciarams87 ciarams87 added this to the v2.3.0 milestone Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants