Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Go build info from the binary #2740

Merged
merged 3 commits into from
Jun 13, 2022
Merged

Use Go build info from the binary #2740

merged 3 commits into from
Jun 13, 2022

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Jun 7, 2022

Go 1.18 adds new fields to the binary's info when compiled in a directory with version control. https://go.dev/doc/go1.18#debug/buildinfo

The commit and date are now read from the binary, along with a few more fields

@lucacome lucacome requested a review from a team June 7, 2022 00:02
@lucacome lucacome self-assigned this Jun 7, 2022
@lucacome lucacome requested review from haywoodsh, ciarams87 and jjngx June 7, 2022 00:02
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jun 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2022

Codecov Report

Merging #2740 (11d59b6) into main (8213749) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2740      +/-   ##
==========================================
- Coverage   53.57%   53.49%   -0.08%     
==========================================
  Files          52       52              
  Lines       14786    14804      +18     
==========================================
- Hits         7922     7920       -2     
- Misses       6599     6619      +20     
  Partials      265      265              
Impacted Files Coverage Δ
cmd/nginx-ingress/main.go 6.62% <0.00%> (-0.20%) ⬇️
...ternal/k8s/appprotect/app_protect_configuration.go 86.16% <0.00%> (-0.58%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@lucacome lucacome merged commit 35c128a into main Jun 13, 2022
@lucacome lucacome deleted the chore/use-go-build-info branch June 13, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants