-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minReadySeconds & strategy support #2672
Add minReadySeconds & strategy support #2672
Conversation
@cmk-pcs Could you please open a corresponding issue to help us track your PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cmk-pcs
Thanks for the PR!
Would you mind also adding the new fields and comments in deployments/helm-chart/values.yaml
?
Could you also add the equivalent for the DaemonSet
?
Thanks.
Co-authored-by: Luca Comellini <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2672 +/- ##
==========================================
+ Coverage 53.39% 53.48% +0.08%
==========================================
Files 52 52
Lines 14706 14751 +45
==========================================
+ Hits 7853 7889 +36
- Misses 6591 6599 +8
- Partials 262 263 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Proposed changes
Adding support for deployment strategy and minReadySeconds to helm chart.
Checklist
Before creating a PR, run through this checklist and mark each as complete.