-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct spelling mistakes #2645
Changes from all commits
018d226
dd49ab0
71834e3
6db850d
f895301
8a0152c
c8e2667
4c186ba
8a165c6
bab915f
90139f0
1c921d2
cfaa0a5
e4064fc
b322df5
489ce36
880851d
39695a7
6ca4522
b370fed
03acf0f
29da1be
d01147a
8205a84
480ca47
92bfc84
80694f2
41cd30c
72b30df
38514c9
9961427
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -73,7 +73,7 @@ The table below summarizes the options regarding the images, manifests, helm cha | |
|
||
## Contacts | ||
|
||
We’d like to hear your feedback! If you have any suggestions or experience issues with our Ingress Controller, please create an issue or send a pull request on Github. | ||
We’d like to hear your feedback! If you have any suggestions or experience issues with our Ingress Controller, please create an issue or send a pull request on GitHub. | ||
You can contact us directly via [[email protected]](mailto:[email protected]) or on the [NGINX Community Slack](https://nginxcommunity.slack.com/channels/nginx-ingress-controller). | ||
|
||
## Contributing | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,7 +31,7 @@ spec: | |
metadata: | ||
type: object | ||
spec: | ||
description: DosProtectedResourceSpec deines the properties and values a DosProtectedResource can have. | ||
description: DosProtectedResourceSpec defines the properties and values a DosProtectedResource can have. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the CRD are automatically generated, so we need to change the source pinging @rafwegv |
||
type: object | ||
properties: | ||
apDosMonitor: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -115,7 +115,7 @@ rateLimit: | |
|``delay`` | The delay parameter specifies a limit at which excessive requests become delayed. If not set all excessive requests are delayed. | ``int`` | No | | ||
|``noDelay`` | Disables the delaying of excessive requests while requests are being limited. Overrides ``delay`` if both are set. | ``bool`` | No | | ||
|``burst`` | Excessive requests are delayed until their number exceeds the ``burst`` size, in which case the request is terminated with an error. | ``int`` | No | | ||
|``dryRun`` | Enables the dry run mode. In this mode, the rate limit is not actually applied, but the the number of excessive requests is accounted as usual in the shared memory zone. | ``bool`` | No | | ||
|``dryRun`` | Enables the dry run mode. In this mode, the rate limit is not actually applied, but the number of excessive requests is accounted as usual in the shared memory zone. | ``bool`` | No | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Doubled words are a new area for me. I'm still not terribly confident about them. I understand that things like this probably will require a chart release. I'll cross that bridge at the end. |
||
|``logLevel`` | Sets the desired logging level for cases when the server refuses to process requests due to rate exceeding, or delays request processing. Allowed values are ``info``, ``notice``, ``warn`` or ``error``. Default is ``error``. | ``string`` | No | | ||
|``rejectCode`` | Sets the status code to return in response to rejected requests. Must fall into the range ``400..599``. Default is ``503``. | ``string`` | No | | ||
{{% /table %}} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,7 +22,7 @@ Create the application deployment, service and secret: | |
$ kubectl apply -f secure-app.yaml | ||
``` | ||
## Step 2 - Deploy the Egress MLTS Secret | ||
## Step 2 - Deploy the Egress MTLS Secret | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. !! |
||
Create a secret with the name `egress-mtls-secret` that will be used for authentication to application: | ||
``` | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,7 +19,7 @@ metadata: | |
spec: | ||
host: grpc.example.com | ||
tls: | ||
secret: gprc-secret | ||
secret: grpc-secret | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ?! |
||
upstreams: | ||
- name: grpc1 | ||
service: grpc-svc | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
|
||
%%TITLE%% | ||
|
||
An automatically generated list of changes can be found on Github at: [%%IC_VERSION%% Release](https://github.com/nginxinc/kubernetes-ingress/releases/tag/v%%IC_VERSION%%) | ||
An automatically generated list of changes can be found on GitHub at: [%%IC_VERSION%% Release](https://github.com/nginxinc/kubernetes-ingress/releases/tag/v%%IC_VERSION%%) | ||
|
||
A curated list of changes can be found on the [Releases](http://docs.nginx.com/nginx-ingress-controller/releases/) page on the NGINX Documentation website. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -416,7 +416,7 @@ func TestGenerateNginxCfgForMergeableIngressesForJWT(t *testing.T) { | |
mergeableIngresses.Minions[0].Ingress.Annotations["nginx.com/jwt-key"] = "coffee-jwk" | ||
mergeableIngresses.Minions[0].Ingress.Annotations["nginx.com/jwt-realm"] = "Coffee" | ||
mergeableIngresses.Minions[0].Ingress.Annotations["nginx.com/jwt-token"] = "$cookie_auth_token_coffee" | ||
mergeableIngresses.Minions[0].Ingress.Annotations["nginx.com/jwt-login-url"] = "https://login.cofee.example.com" | ||
mergeableIngresses.Minions[0].Ingress.Annotations["nginx.com/jwt-login-url"] = "https://login.coffee.example.com" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm assuming there aren't any hashes that care about this change. |
||
mergeableIngresses.Minions[0].SecretRefs["coffee-jwk"] = &secrets.SecretReference{ | ||
Secret: &v1.Secret{ | ||
Type: secrets.SecretTypeJWK, | ||
|
@@ -446,7 +446,7 @@ func TestGenerateNginxCfgForMergeableIngressesForJWT(t *testing.T) { | |
}, | ||
{ | ||
Name: "@login_url_default-cafe-ingress-coffee-minion", | ||
LoginURL: "https://login.cofee.example.com", | ||
LoginURL: "https://login.coffee.example.com", | ||
}, | ||
} | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -88,7 +88,7 @@ | |
|
||
# location /api/ { | ||
# api write=on; | ||
# allow 127.0.0.1; # Only the NGINX host may call the NIGNX Plus API | ||
# allow 127.0.0.1; # Only the NGINX host may call the NGINX Plus API | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Brand |
||
# deny all; | ||
# access_log off; | ||
# } | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brand.
Some projects don't like changing changelogs. I can drop files if requested.