Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbind policy from preview policies #2566

Merged
merged 8 commits into from
Apr 6, 2022

Conversation

haywoodsh
Copy link
Contributor

@haywoodsh haywoodsh commented Mar 30, 2022

Proposed changes

Policy settings are no longer gated through the use of -enable-preview-policies

Affected policies:

  • RateLimit
  • JWT
  • IngressMTLS
  • EgressMTLS

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements labels Mar 30, 2022
@haywoodsh haywoodsh force-pushed the feature/unbind-policy-from-preview-policies branch from aaba6c4 to ea791b9 Compare March 30, 2022 21:51
@haywoodsh haywoodsh marked this pull request as ready for review March 30, 2022 21:52
@lucacome lucacome requested review from a team, lucacome, ciarams87 and jjngx March 31, 2022 17:57
Copy link
Contributor

@jputrino jputrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I'd like to make sure we review the deploy preview as well. That should get kicked off the next time a commit is made to this feature branch.

@haywoodsh haywoodsh force-pushed the feature/unbind-policy-from-preview-policies branch from ea791b9 to 0aee8ec Compare April 5, 2022 10:36
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2022

Codecov Report

Merging #2566 (8e6f52f) into main (89a49b7) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 8e6f52f differs from pull request most recent head 0ccd340. Consider uploading reports for the commit 0ccd340 to get more accurate results

@@            Coverage Diff             @@
##             main    #2566      +/-   ##
==========================================
- Coverage   53.52%   53.47%   -0.05%     
==========================================
  Files          49       49              
  Lines       14314    14301      -13     
==========================================
- Hits         7661     7648      -13     
+ Misses       6412     6410       -2     
- Partials      241      243       +2     
Impacted Files Coverage Δ
pkg/apis/configuration/validation/policy.go 96.55% <ø> (+0.91%) ⬆️
internal/k8s/configuration.go 95.47% <0.00%> (-0.39%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@lucacome lucacome requested a review from pleshakov April 5, 2022 17:18
@haywoodsh haywoodsh enabled auto-merge (squash) April 6, 2022 10:34
@haywoodsh haywoodsh merged commit 069ca8e into main Apr 6, 2022
@haywoodsh haywoodsh deleted the feature/unbind-policy-from-preview-policies branch April 6, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants