Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend helm chart to include NSM fields #2525

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Extend helm chart to include NSM fields #2525

merged 2 commits into from
Mar 23, 2022

Conversation

kate-osborn
Copy link
Contributor

Proposed changes

Extends the helm chart to include fields to configure integration with NGINX Service Mesh. Adds a values-nsm.yaml file will all NGINX Service Mesh related fields set.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@lucacome lucacome requested review from a team, haywoodsh, jjngx and shaun-nx March 22, 2022 18:11
@lucacome lucacome added the enhancement Pull requests for new features/feature enhancements label Mar 22, 2022
jjngx
jjngx approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@lucacome lucacome merged commit 844bee9 into nginx:main Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjngx jjngx jjngx approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

@haywoodsh haywoodsh Awaiting requested review from haywoodsh haywoodsh was automatically assigned from nginxinc/kic

@shaun-nx shaun-nx Awaiting requested review from shaun-nx shaun-nx was automatically assigned from nginxinc/kic

Assignees
No one assigned
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kate-osborn @ciarams87 @jjngx @lucacome