Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra checkout step #2505

Merged
merged 1 commit into from
Mar 17, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions deployments/helm-chart-dos-arbitrator/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,18 @@ This chart deploys the NGINX App Protect Dos Arbitrator in your Kubernetes clust
- A [Kubernetes Version Supported by the Ingress Controller](https://docs.nginx.com/nginx-ingress-controller/technical-specifications/#supported-kubernetes-versions)
- Helm 3.0+.
- Git.

## Getting the Chart Sources

This step is required if you're installing the chart using its sources. Additionally, the step is also required for managing the custom resource definitions (CRDs), which the Ingress Controller requires by default, or for upgrading/deleting the CRDs.

1. Clone the Ingress controller repo:
```console
$ git clone https://github.com/nginxinc/kubernetes-ingress/
$ git clone https://github.com/nginxinc/kubernetes-ingress.git --branch v2.1.1
```
2. Change your working directory to /deployments/helm-chart-dos-arbitrator:
```console
$ cd kubernetes-ingress/deployments/helm-chart-dos-arbitrator
$ git checkout v2.1.0
```

## Adding the Helm Repository
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,11 @@ This step is required if you're installing the chart using its sources. Addition

1. Clone the Ingress controller repo:
```console
$ git clone https://github.com/nginxinc/kubernetes-ingress/
$ git clone https://github.com/nginxinc/kubernetes-ingress.git --branch v2.1.1
```
2. Change your working directory to /deployments/helm-chart-dos-arbitrator:
```console
$ cd kubernetes-ingress/deployments/helm-chart-dos-arbitrator
$ git checkout v2.1.1
```

## Adding the Helm Repository
Expand Down
3 changes: 1 addition & 2 deletions docs/content/app-protect-dos/installation.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,8 @@ This document provides an overview of the steps required to use NGINX App Protec
* It is also possible to build your own image and push it to your private Docker registry by following the instructions from [here](/nginx-ingress-controller/installation/building-ingress-controller-image).
2. Clone the Ingress controller repo:
```
$ git clone https://github.com/nginxinc/kubernetes-ingress/
$ git clone https://github.com/nginxinc/kubernetes-ingress.git --branch v2.1.1
$ cd kubernetes-ingress
$ git checkout v2.1.1
```

## Create the namespace and service account
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,8 @@ We build the image using the make utility and the provided `Makefile`. Let’s c

1. Clone the Ingress Controller repo:
```
$ git clone https://github.com/nginxinc/kubernetes-ingress/
$ git clone https://github.com/nginxinc/kubernetes-ingress.git --branch v2.1.1
$ cd kubernetes-ingress
$ git checkout v2.1.1
```

1. Build the image:
Expand Down
5 changes: 2 additions & 3 deletions docs/content/installation/installation-with-helm.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
title: Installation with Helm
description: "This document describes how to install the NGINX Ingress Controller in your Kubernetes cluster using Helm."
description: "This document describes how to install the NGINX Ingress Controller in your Kubernetes cluster using Helm."
weight: 1900
doctypes: [""]
toc: true
Expand Down Expand Up @@ -28,12 +28,11 @@ This step is required if you're installing the chart using its sources. Addition

1. Clone the Ingress controller repo:
```console
$ git clone https://github.com/nginxinc/kubernetes-ingress/
$ git clone https://github.com/nginxinc/kubernetes-ingress.git --branch v2.1.1
```
2. Change your working directory to /deployments/helm-chart:
```console
$ cd kubernetes-ingress/deployments/helm-chart
$ git checkout v2.1.1
```

## Adding the Helm Repository
Expand Down
3 changes: 1 addition & 2 deletions docs/content/installation/installation-with-manifests.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,8 @@ This document describes how to install the NGINX Ingress Controller in your Kube
* It is also possible to build your own image and push it to your private Docker registry by following the instructions from [here](/nginx-ingress-controller/installation/building-ingress-controller-image).
2. Clone the Ingress controller repo and change into the deployments folder:
```
$ git clone https://github.com/nginxinc/kubernetes-ingress/
$ git clone https://github.com/nginxinc/kubernetes-ingress.git --branch v2.1.1
$ cd kubernetes-ingress/deployments
$ git checkout v2.1.1
```

## 1. Configure RBAC
Expand Down