Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in file nginx-plus.virtualserver.tmpl ApDosMonitor->ApDosMonitorURI #2414

Merged
merged 2 commits into from
Feb 24, 2022

Conversation

pasmant
Copy link
Contributor

@pasmant pasmant commented Feb 6, 2022

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

Sorry, something went wrong.

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2022

Codecov Report

Merging #2414 (2869c16) into master (c4d49db) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 2869c16 differs from pull request most recent head 6a8d9be. Consider uploading reports for the commit 6a8d9be to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2414      +/-   ##
==========================================
+ Coverage   53.66%   53.68%   +0.02%     
==========================================
  Files          48       48              
  Lines       14200    14203       +3     
==========================================
+ Hits         7620     7625       +5     
+ Misses       6342     6340       -2     
  Partials      238      238              
Impacted Files Coverage Δ
internal/nginx/utils.go 0.00% <0.00%> (ø)
internal/nginx/manager.go 0.00% <0.00%> (ø)
internal/metrics/collectors/processes.go 0.00% <0.00%> (ø)
internal/configs/virtualserver.go 95.32% <0.00%> (+<0.01%) ⬆️
internal/configs/transportserver.go 93.87% <0.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4d49db...6a8d9be. Read the comment docs.

@pleshakov pleshakov added the bug An issue reporting a potential bug label Feb 8, 2022
@lucacome
Copy link
Member

@pasmant can this be merged?

@pasmant
Copy link
Contributor Author

pasmant commented Feb 24, 2022

@pasmant can this be merged?

Yes, we can merged it.

I don't have permission to do the merge.

@lucacome lucacome enabled auto-merge (squash) February 24, 2022 07:21
@lucacome lucacome merged commit 9d6419e into nginx:master Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants