Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JWT in tests and add flaky reruns to common failures #2349

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Update JWT in tests and add flaky reruns to common failures #2349

merged 1 commit into from
Jan 11, 2022

Conversation

ciarams87
Copy link
Contributor

Proposed changes

The minion JWT token in the TestJWTAuthMergeableMinions::test_jwt_auth_response_codes_and_location test expired Sunday 9th Jan 22. This commit removes the expiry date from the recreated token. It also adds retries to two tests that have habitual failures.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@ciarams87 ciarams87 added the tests Pull requests that update tests label Jan 11, 2022
@ciarams87 ciarams87 merged commit fed389d into master Jan 11, 2022
@ciarams87 ciarams87 deleted the update-jwt-tests branch January 11, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasohaodha tomasohaodha tomasohaodha approved these changes

Assignees
No one assigned
Labels
tests Pull requests that update tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ciarams87 @tomasohaodha