-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add handling of multiple log destinations #2328
Conversation
1f52096
to
f732580
Compare
f732580
to
79b7fa8
Compare
d3c8896
to
f2ad94b
Compare
Codecov Report
@@ Coverage Diff @@
## main #2328 +/- ##
==========================================
+ Coverage 53.47% 53.51% +0.03%
==========================================
Files 52 52
Lines 14696 14729 +33
==========================================
+ Hits 7859 7882 +23
- Misses 6577 6583 +6
- Partials 260 264 +4
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
10d8fb9
to
ac21b74
Compare
fbc8f61
to
b6414c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments, also one of the files is not properly formatted, that's why there's a linting error
a73c708
to
e93d010
Compare
e93d010
to
e8c42d4
Compare
38bc8fa
to
cb0dfaa
Compare
d4d6bce
to
83897e9
Compare
Proposed changes
Add a field to policy crd which allows for specifying multiple log destinations. If the old field is used with the new field the old field is ignored. Otherwise old OR new fields work
Checklist
Before creating a PR, run through this checklist and mark each as complete.