Fix URI rewrite in VirtualServers and VirtualServerRoutes #2267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vepatel
approved these changes
Dec 13, 2021
vepatel
reviewed
Dec 13, 2021
ciarams87
approved these changes
Dec 13, 2021
pleshakov
force-pushed
the
fix-uri-rewrite
branch
from
d836ea3 to
a087392
Compare
nginx-bot
force-pushed
the
fix-uri-rewrite
branch
2 times, most recently
from
d7e1137 to
d6c8c80
Compare
Previously, if a rewrite was configured in a VS/VSR route, and the route had a split action, match action or a regex path, NGINX would mess up the arguments in the resulting rewrite. For example, the result would be /test%3Fhello=world?hello=world instead of the correct /test?hello=world Fixes #1993
- Combine the VS and VSR tests into a single one. - Extend the tests to cover the bug fix.
nginx-bot
force-pushed
the
fix-uri-rewrite
branch
from
d6c8c80 to
e84ca42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Previously, if a rewrite was configured in a VS/VSR route, and the route had a split action, match action or a regex path, NGINX would mess up the arguments in the resulting rewrite. For example, the result would be
/test%3Fhello=world?hello=worldinstead of the correct/test?hello=worldFixes #1993
Tests: