Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if refresh token is undefined and do not store it in this case #2260

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

tippexs
Copy link
Contributor

@tippexs tippexs commented Dec 8, 2021

Proposed changes

In some cases the token response from the Identity Provider (IdP) does not contain a refresh token. In this case the variable tokenset.refresh_token will be undefined. As undefined is unequal to the current refresh-token undefined is stored as the tokens value in the key-value store. This results in a deletion of the token from the key-value-store.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • [X ] I have read the CONTRIBUTING doc
  • [X ] I have added tests that prove my fix is effective or that my feature works
  • [ X] I have checked that all unit tests pass after adding my changes
  • [ X] I have updated necessary documentation
  • [ X ] I have rebased my branch onto master
  • [ X] I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2021

Codecov Report

Merging #2260 (fd70a12) into master (6b6c675) will not change coverage.
The diff coverage is n/a.

❗ Current head fd70a12 differs from pull request most recent head 6b54acf. Consider uploading reports for the commit 6b54acf to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2260   +/-   ##
=======================================
  Coverage   53.39%   53.39%           
=======================================
  Files          43       43           
  Lines       13413    13413           
=======================================
  Hits         7162     7162           
  Misses       6022     6022           
  Partials      229      229           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b6c675...6b54acf. Read the comment docs.

@lucacome lucacome merged commit 2c653da into nginx:master Dec 9, 2021
@pleshakov
Copy link
Contributor

@lucacome @tippexs is it a bug fix? shall we tag it as a bug fix?

@lucacome
Copy link
Member

lucacome commented Dec 9, 2021

yeah I think it makes sense to add the bug label

@lucacome lucacome added the bug An issue reporting a potential bug label Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants