-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: try and get pipeline green again #2259
Conversation
70370c8
to
ad91a59
Compare
Codecov Report
@@ Coverage Diff @@
## master #2259 +/- ##
==========================================
- Coverage 53.39% 53.38% -0.02%
==========================================
Files 43 43
Lines 13412 13409 -3
==========================================
- Hits 7161 7158 -3
Misses 6022 6022
Partials 229 229
Continue to review full report at Codecov.
|
976186e
to
7cefd29
Compare
|
||
RUN apt-get update && apt-get install -y curl git jq \ | ||
&& curl -LO https://storage.googleapis.com/kubernetes-release/release/$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)/bin/linux/amd64/kubectl \ | ||
&& chmod +x ./kubectl \ | ||
&& mv ./kubectl /usr/local/bin \ | ||
&& curl -O https://dl.google.com/dl/cloudsdk/channels/rapid/downloads/google-cloud-sdk-${GCLOUD_VERSION}-linux-x86_64.tar.gz \ | ||
&& tar xvzf google-cloud-sdk-${GCLOUD_VERSION}-linux-x86_64.tar.gz \ | ||
&& mv google-cloud-sdk /usr/lib/ | ||
&& mv google-cloud-sdk /usr/lib/ \ | ||
&& curl -LO https://get.helm.sh/helm-v${HELM_VERSION}-linux-amd64.tar.gz \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find changes related to this. Why do we need to install helm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The helm tests run on GKE because of networking issues in gitlab. Now that we have moved the GKE setup to the before_script
, the helm tests run on the same runner as the GKE setup runner, and I thought it made more sense to have everything use the same image rather than have an entire separate logic for just helm.
7cefd29
to
d65b0a8
Compare
d65b0a8
to
377c46c
Compare
Proposed changes
(to be taken in conjunction with gitlab pipeline changes)
Changes:
In the latest run, we had a failure due to GKE quotas because we were testing two nightly pipelines at once - we won't have that in future. This isn't a fix for all our problems, but more of a "round-1" effort.
At the moment we are still running the PR Plus tests in both GitHub and GitLab, we can decide later which path to choose.
See https://gitlab.com/f5/nginx/kic/kubernetes-ingress/-/pipelines/430470455 for the green PR run and https://gitlab.com/f5/nginx/kic/kubernetes-ingress/-/pipelines/430330791 for the green nightly run.
Checklist
Before creating a PR, run through this checklist and mark each as complete.