-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable setting mandatory and persistent in upstream healthchecks in VS and VSR #2251
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2251 +/- ##
=======================================
Coverage 53.41% 53.42%
=======================================
Files 43 43
Lines 13412 13419 +7
=======================================
+ Hits 7164 7169 +5
Misses 6020 6020
- Partials 228 230 +2
Continue to review full report at Codecov.
|
d9c0e2b
to
0b72171
Compare
b5c49f3
to
c502a1c
Compare
2d2b0c2
to
0655f94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 (with some doc related suggestions)
docs/content/configuration/virtualserver-and-virtualserverroute-resources.md
Outdated
Show resolved
Hide resolved
docs/content/configuration/virtualserver-and-virtualserverroute-resources.md
Outdated
Show resolved
Hide resolved
0655f94
to
9b6e8c3
Compare
@ciarams87 sorry for the late review |
9b6e8c3
to
1532ee7
Compare
Proposed changes
See mandatory-health-checks
The mandatory parameter requires every newly added server to pass all configured health checks before NGINX Plus sends traffic to it. When combined with slow start, it gives a new server more time to connect to databases and “warm up” before being asked to handle their full share of traffic. Mandatory health checks can be marked as persistent, so that the previous state is remembered when reloading configuration.
Checklist
Before creating a PR, run through this checklist and mark each as complete.