Add content-type header
to grpc error locations
#2229
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The gRPC Go client shows errors when handling error pages returned from the IC (e.g. when a backend is unavailable). This resolves one of the issues (malformed header response), e.g.:
Current error:
./grpc_client -address virtual-server.example.com:443 2021/11/30 14:32:41 could not greet: rpc error: code = Unknown desc = unexpected HTTP status code received from server: 204 (No Content); malformed header: missing HTTP content-type
After this commit:
./grpc_client -address virtual-server.example.com:443 2021/11/30 14:21:05 could not greet: rpc error: code = Unknown desc = unexpected HTTP status code received from server: 204 (No Content)
Checklist
Before creating a PR, run through this checklist and mark each as complete.