-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add grpc_status to the logs #2216
Conversation
e10a45a
to
6f1b7e6
Compare
203ccc0
to
9ec09ad
Compare
e53954f
to
0e981bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ciarams87 Please see my comments and suggestions
b503c49
to
7da432b
Compare
50f6d74
to
82b0292
Compare
177a827
to
a9d4647
Compare
a9d4647
to
98fd68d
Compare
Codecov Report
@@ Coverage Diff @@
## master #2216 +/- ##
==========================================
- Coverage 53.33% 53.29% -0.05%
==========================================
Files 43 43
Lines 13392 13392
==========================================
- Hits 7143 7137 -6
- Misses 6020 6024 +4
- Partials 229 231 +2
Continue to review full report at Codecov.
|
Proposed changes
Add new custom log field for gRPC status.
Checklist
Before creating a PR, run through this checklist and mark each as complete.