Generate error page warnings for gRPC upstreams #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soneillf5
approved these changes
Nov 18, 2021
|
Lots of tests, great stuff |
ciarams87
changed the title
nginx-bot
force-pushed
the
chore/generate-error-page-warnings
branch
3 times, most recently
from
4c60a0a to
18a28c4
Compare
pleshakov
reviewed
Nov 20, 2021
nginx-bot
force-pushed
the
chore/generate-error-page-warnings
branch
3 times, most recently
from
349e8ff to
f744cb1
Compare
ciarams87
force-pushed
the
chore/generate-error-page-warnings
branch
3 times, most recently
from
293df52 to
470f1d2
Compare
nginx-bot
force-pushed
the
chore/generate-error-page-warnings
branch
3 times, most recently
from
d6855db to
9651ca0
Compare
ciarams87
force-pushed
the
chore/generate-error-page-warnings
branch
from
9651ca0 to
c55cdf6
Compare
ciarams87
changed the title
ciarams87
force-pushed
the
chore/generate-error-page-warnings
branch
from
c55cdf6 to
01b0ef5
Compare
|
@pleshakov Can you please re-review when you get a chance? Thank you! |
ciarams87
force-pushed
the
chore/generate-error-page-warnings
branch
2 times, most recently
from
190b3d9 to
0e6cc68
Compare
nginx-bot
force-pushed
the
chore/generate-error-page-warnings
branch
3 times, most recently
from
a3c15fd to
974015c
Compare
pleshakov
reviewed
Dec 4, 2021
ciarams87
force-pushed
the
chore/generate-error-page-warnings
branch
10 times, most recently
from
0d9e003 to
bf0f3a7
Compare
pleshakov
approved these changes
Dec 6, 2021
nginx-bot
force-pushed
the
chore/generate-error-page-warnings
branch
from
bf0f3a7 to
b2b0f1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Generate an error when a user configures one or more gRPC Upstreams in the VirtualServer resource with a custom error page which conflicts with the ones generated for a gRPC upstream (one of 400, 401, 403, 404, 405, 408, 413, 414, 415, 426, 429, 495, 496, 497, 500, 501, 502, 503, 504)
Checklist
Before creating a PR, run through this checklist and mark each as complete.