-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move custom-resources with other examples #2157
Conversation
7d88623
to
b79cd9e
Compare
I agree with this change in principle, but would appreciate @brianehlert especially chiming in. |
custom resources is a big group of examples that covers a lot of use cases. however, with the current layout, they are somewhat hidden among Ingress resource examples: imho it would be better if we have the following structure:
Also, perhaps we can come up with a better name than just "custom resources"? @brianehlert |
I agree that it is valuable. And that "custom-resources" is too generic / obscure. consumers look for answers based on the use case first and how to implement is the choice. |
b79cd9e
to
c3ff338
Compare
I would agree with all previous comments, however I would recommend approving this PR and merging the basic location change. Further changes can come in further PRs after more discussion. Perfect enemy of the good and all that. |
I don't think we should merge the current state of the PR. As I mentioned previously, the new layout hides custom resource related examples. Note that the regular and custom resource examples are supposed to be equal alternatives to each other -- that's why there were two separate folders in the root directory. With the new layout, the custom resource examples are hidden away. |
04f4e40
to
516f17d
Compare
516f17d
to
71885a6
Compare
I think it makes it cleaner to have all the examples inside one folder.