Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more badges to README #2156

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Add more badges to README #2156

merged 1 commit into from
Apr 12, 2022

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Nov 3, 2021

Adding a few badges

@lucacome lucacome added the proposal An issue that proposes a feature request label Nov 3, 2021
@lucacome lucacome self-assigned this Nov 3, 2021
@github-actions github-actions bot added chore Pull requests for routine tasks documentation Pull requests/issues for documentation labels Nov 3, 2021
@lucacome lucacome force-pushed the chore/add-more-badges branch from 50472f3 to 8679681 Compare November 3, 2021 22:08
@nginx-bot nginx-bot force-pushed the chore/add-more-badges branch from 8679681 to ad3c9f1 Compare November 4, 2021 10:41
@tomasohaodha
Copy link
Contributor

For something like this, I have to ask:
What are we trying to communicate with the badges? For example, why is it important to show how large our image is?

@nginx-bot nginx-bot force-pushed the chore/add-more-badges branch 9 times, most recently from b0c11ed to 96f7929 Compare November 11, 2021 12:04
@nginx-bot nginx-bot force-pushed the chore/add-more-badges branch 10 times, most recently from 56a75bc to de3536a Compare November 18, 2021 18:16
@nginx-bot nginx-bot force-pushed the chore/add-more-badges branch 4 times, most recently from 09d1457 to 1809488 Compare November 22, 2021 18:48
@nginx-bot nginx-bot force-pushed the chore/add-more-badges branch 6 times, most recently from 4f8b8c2 to 8e6a279 Compare November 29, 2021 19:40
@nginx-bot nginx-bot force-pushed the chore/add-more-badges branch from 8e6a279 to 55ceb9d Compare November 29, 2021 23:35
@lucacome lucacome force-pushed the chore/add-more-badges branch 2 times, most recently from a3d0b2c to c5f89ad Compare March 26, 2022 01:33
@nginx nginx deleted a comment from codecov-commenter Mar 26, 2022
@lucacome lucacome requested review from a team, ciarams87, jjngx and shaun-nx March 26, 2022 01:34
@lucacome lucacome force-pushed the chore/add-more-badges branch from c5f89ad to f161953 Compare March 26, 2022 01:37
@nginx nginx deleted a comment from codecov-commenter Mar 26, 2022
@nginx nginx deleted a comment from codecov-commenter Mar 26, 2022
@lucacome
Copy link
Member Author

Added Artifact Hub and Slack Channel
Preview https://github.com/nginxinc/kubernetes-ingress/blob/chore/add-more-badges/README.md

@lucacome lucacome requested a review from eufinco March 28, 2022 21:21
@lucacome lucacome merged commit 4ca3b91 into main Apr 12, 2022
@lucacome lucacome deleted the chore/add-more-badges branch April 12, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasohaodha tomasohaodha tomasohaodha approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

@jjngx jjngx Awaiting requested review from jjngx jjngx was automatically assigned from nginxinc/kic

@shaun-nx shaun-nx Awaiting requested review from shaun-nx shaun-nx was automatically assigned from nginxinc/kic

@eufinco eufinco Awaiting requested review from eufinco

Assignees

@lucacome lucacome

Labels
chore Pull requests for routine tasks documentation Pull requests/issues for documentation proposal An issue that proposes a feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucacome @tomasohaodha @ciarams87 @nginx-bot