-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre-commit configuration #2154
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nginx-bot
force-pushed
the
chore/add-pre-commit
branch
8 times, most recently
from
November 10, 2021 18:51
e0a3cb2
to
1a29f5f
Compare
nginx-bot
force-pushed
the
chore/add-pre-commit
branch
10 times, most recently
from
November 16, 2021 09:13
dc011a5
to
d2cf8a0
Compare
lucacome
requested review from
a team,
pleshakov and
ciarams87
and removed request for
a team
November 16, 2021 18:23
nginx-bot
force-pushed
the
chore/add-pre-commit
branch
from
November 16, 2021 23:42
d2cf8a0
to
d32432b
Compare
nginx-bot
force-pushed
the
chore/add-pre-commit
branch
3 times, most recently
from
November 18, 2021 20:32
844c632
to
27ca1c7
Compare
nginx-bot
force-pushed
the
chore/add-pre-commit
branch
4 times, most recently
from
November 29, 2021 23:35
424fe0b
to
a2af6c1
Compare
lucacome
force-pushed
the
chore/add-pre-commit
branch
from
January 11, 2022 19:01
10d638f
to
a95be88
Compare
Codecov Report
@@ Coverage Diff @@
## main #2154 +/- ##
=======================================
Coverage 52.52% 52.52%
=======================================
Files 58 58
Lines 16070 16070
=======================================
Hits 8441 8441
Misses 7351 7351
Partials 278 278 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lucacome
force-pushed
the
chore/add-pre-commit
branch
from
April 6, 2022 02:05
4f221da
to
ea00cba
Compare
Merged
vepatel
approved these changes
Aug 19, 2022
lucacome
force-pushed
the
chore/add-pre-commit
branch
from
November 3, 2022 02:55
1e6d5bd
to
9e81403
Compare
haywoodsh
approved these changes
Nov 3, 2022
jjngx
approved these changes
Nov 3, 2022
coolbry95
pushed a commit
to coolbry95/kubernetes-ingress
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding configuration for https://pre-commit.com/ with this we can have checks that run automatically before committing and (in most cases) fix the problems.
Here the quick start for installing it, basically:
brew install pre-commit
followed bypre-commit install
. After that, it will run before every commit.I've added some hooks in the config (there are many more):
There's an option to run it as a check in GitHub so external contributors don't need to install it, but the checks will still be enforced. (https://pre-commit.ci/)
Let me know what you think.