Add metric about total number of TransportServers #2149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
pleshakov
force-pushed
the
feature/ts-metrics
branch
3 times, most recently
from
ffcf9f0 to
883ed69
Compare
soneillf5
reviewed
Nov 2, 2021
nginx-bot
force-pushed
the
feature/ts-metrics
branch
3 times, most recently
from
4916525 to
ad19cdc
Compare
nginx-bot
force-pushed
the
feature/ts-metrics
branch
from
ad19cdc to
bacd37e
Compare
lucacome
approved these changes
Nov 4, 2021
nginx-bot
force-pushed
the
feature/ts-metrics
branch
from
bacd37e to
de4039a
Compare
pleshakov
force-pushed
the
feature/ts-metrics
branch
from
de4039a to
6b2e372
Compare
|
@soneillf5 @lucacome the previous tests failure was cause by a bug (panic because of nil pointer). this fixes the bug -- 6b2e372 |
nginx-bot
force-pushed
the
feature/ts-metrics
branch
from
6b2e372 to
5d9d438
Compare
soneillf5
approved these changes
Nov 8, 2021
pleshakov
force-pushed
the
feature/ts-metrics
branch
from
5d9d438 to
a774736
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add a new Prometheus metric about TransportServers:
controller_transportserver_resources_total. Number of handled TransportServer resources. This metric includes the label type, that groups the TransportServer resources by their type (passthrough, tcp or udp).