Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support gRPC in the Upstreams of the virtual server resources #2110

Merged
merged 10 commits into from
Nov 11, 2021
Merged

Support gRPC in the Upstreams of the virtual server resources #2110

merged 10 commits into from
Nov 11, 2021

Conversation

ciarams87
Copy link
Contributor

@ciarams87 ciarams87 commented Oct 19, 2021 •
edited
Loading

Proposed changes

Support gRPC in the Upstreams of the virtual server resources.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@github-actions github-actions bot added documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements labels Oct 19, 2021
@ciarams87 ciarams87 force-pushed the feat/enable-gprc-vs-upstreams branch 3 times, most recently from 822f187 to b5ca0bd Compare October 21, 2021 17:23
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Oct 21, 2021
@ciarams87 ciarams87 force-pushed the feat/enable-gprc-vs-upstreams branch 9 times, most recently from b6cfe27 to 19376f0 Compare October 26, 2021 16:55
@ciarams87 ciarams87 marked this pull request as ready for review October 26, 2021 16:56
@ciarams87 ciarams87 force-pushed the feat/enable-gprc-vs-upstreams branch from 19376f0 to afc6351 Compare October 26, 2021 17:10
@ciarams87 ciarams87 changed the title Draft: Support gRPC in the Upstreams of the virtual server resources Support gRPC in the Upstreams of the virtual server resources Oct 26, 2021
@ciarams87 ciarams87 force-pushed the feat/enable-gprc-vs-upstreams branch 6 times, most recently from 77b49c7 to d61496d Compare October 27, 2021 15:25
@ciarams87 ciarams87 force-pushed the feat/enable-gprc-vs-upstreams branch from 5b901b6 to c476d27 Compare October 28, 2021 14:47
@ciarams87 ciarams87 force-pushed the feat/enable-gprc-vs-upstreams branch from d64f4ee to c3b2127 Compare November 1, 2021 14:29
pleshakov
pleshakov reviewed Nov 3, 2021
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ciarams87 please see new feedback

internal/configs/version2/nginx-plus.virtualserver.tmpl Outdated Show resolved Hide resolved
internal/configs/version2/nginx-plus.virtualserver.tmpl Show resolved Hide resolved
internal/configs/version2/nginx-plus.virtualserver.tmpl Show resolved Hide resolved
internal/configs/version2/nginx-plus.virtualserver.tmpl Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/virtualserver.go Outdated Show resolved Hide resolved
examples-of-custom-resources/grpc-upstreams/README.md Outdated Show resolved Hide resolved
examples-of-custom-resources/grpc-upstreams/README.md Outdated Show resolved Hide resolved
examples-of-custom-resources/grpc-upstreams/README.md Outdated Show resolved Hide resolved
examples-of-custom-resources/grpc-upstreams/README.md Outdated Show resolved Hide resolved
examples-of-custom-resources/grpc-upstreams/README.md Outdated Show resolved Hide resolved
@ciarams87 ciarams87 force-pushed the feat/enable-gprc-vs-upstreams branch 3 times, most recently from 7ec9e2b to 67217f6 Compare November 4, 2021 12:01
@ciarams87 ciarams87 force-pushed the feat/enable-gprc-vs-upstreams branch from e956b5b to f147399 Compare November 8, 2021 11:10
pleshakov
pleshakov reviewed Nov 9, 2021
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ciarams87 there is one pending comment, but otherwise looks good to me! thanks for addressing the feedback 👍

internal/configs/virtualserver.go Outdated Show resolved Hide resolved
@ciarams87 ciarams87 force-pushed the feat/enable-gprc-vs-upstreams branch 2 times, most recently from f92c148 to 8691458 Compare November 9, 2021 14:19
@ciarams87 ciarams87 force-pushed the feat/enable-gprc-vs-upstreams branch from 8691458 to 0a96ebe Compare November 11, 2021 11:30
@ciarams87 ciarams87 enabled auto-merge (squash) November 11, 2021 11:30
@ciarams87 ciarams87 merged commit 61f25e8 into master Nov 11, 2021
@ciarams87 ciarams87 deleted the feat/enable-gprc-vs-upstreams branch November 11, 2021 11:33
@ciarams87 ciarams87 removed the dependencies Pull requests that update a dependency file label Nov 25, 2021
@lucacome lucacome mentioned this pull request Apr 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel left review comments

@soneillf5 soneillf5 soneillf5 approved these changes

@pleshakov pleshakov pleshakov approved these changes

@lucacome lucacome Awaiting requested review from lucacome

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ciarams87 @pleshakov @vepatel @soneillf5