Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segregate AP methods #2084

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Segregate AP methods #2084

merged 1 commit into from
Oct 14, 2021

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Oct 13, 2021 •
edited
Loading

Proposed changes

  • Segregate AP methods from custom_resources_utils

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@nginx-bot nginx-bot force-pushed the tests/refactor-custom-res-ap branch from 4412019 to 3beb041 Compare October 13, 2021 19:36
@vepatel vepatel merged commit f7a3542 into master Oct 14, 2021
@vepatel vepatel deleted the tests/refactor-custom-res-ap branch October 14, 2021 10:08
@lucacome lucacome added the tests Pull requests that update tests label Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@lucacome lucacome lucacome approved these changes

@ciarams87 ciarams87 Awaiting requested review from ciarams87

@soneillf5 soneillf5 Awaiting requested review from soneillf5

Assignees
No one assigned
Labels
tests Pull requests that update tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vepatel @lucacome @pleshakov