Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issues with the 404 and robots.txts redirects #2058

Closed
wants to merge 1 commit into from
Closed

Conversation

jputrino
Copy link
Contributor

@jputrino jputrino commented Oct 7, 2021

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).

This PR contains fixes for the docs redirects. Previously, we were seeing the Netlify 404 page for 404s found within docs.nginx.com/nginx-ingress-controller; with this fix, we should see the docs-nginx-com 404 page.

Previous:
image

Fixed:

image

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@github-actions github-actions bot added the bug An issue reporting a potential bug label Oct 7, 2021
@lucacome
Copy link
Member

lucacome commented Oct 8, 2021

This change will be added with #2064

@lucacome lucacome closed this Oct 8, 2021
@lucacome lucacome deleted the DOCOPS-421 branch October 8, 2021 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants