Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for pod startup times with multiple resources #1886

Merged
merged 27 commits into from
Sep 2, 2021

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Aug 20, 2021

Proposed changes

  • Add tests for pod startup times with multiple resources

e.g.:

pytest -s -v -m batch_start --node-ip=$(minikube ip) --batch-start="True" --batch-resources=1000
v1.12.0:

No pods came up in 33 minutes v1.12.0-AP with 1000 AP Ingress resources.
nginx-ingress-66696fbd78-kfx87   0/1     Running   0          33m    (Cancelled)

All pods are ContainersReady
All pods came up in 743 seconds v1.12.0-AP with 100 AP Ingress resources.

All pods are ContainersReady
All pods came up in 961 seconds v1.12.0-plus with 1000 simple ingress resources.

All pods are ContainersReady
All pods came up in 20 seconds v1.12.0-plus with 100 simple ingress resources.

edge:

All pods are ContainersReady
All pods came up in 256 seconds edge-ap with 1000 AP(with AP usersig enabled) WAF VS resources.

All pods are ContainersReady
All pods came up in 52 seconds edge-ap with 100 AP(with AP usersig enabled) WAF VS resources.

All pods are ContainersReady
All pods came up in 7 seconds edge-plus with 1000 simple VS resources.

All pods are ContainersReady
All pods came up in 3 seconds edge-plus with 100 simple VS resources.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@vepatel vepatel requested review from pleshakov and soneillf5 August 20, 2021 15:31
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vepatel
Please see my questions and comments

tests/suite/resources_utils.py Outdated Show resolved Hide resolved
tests/suite/resources_utils.py Outdated Show resolved Hide resolved
tests/suite/test_batch_startup_times.py Outdated Show resolved Hide resolved
tests/settings.py Show resolved Hide resolved
tests/suite/test_batch_startup_times.py Show resolved Hide resolved
tests/suite/test_batch_startup_times.py Show resolved Hide resolved
tests/suite/test_batch_startup_times.py Show resolved Hide resolved
tests/suite/test_batch_startup_times.py Show resolved Hide resolved
@vepatel vepatel requested a review from pleshakov September 1, 2021 15:36
@vepatel vepatel merged commit a156618 into master Sep 2, 2021
@vepatel vepatel deleted the tests/multiple-resources branch September 2, 2021 11:39
@ciarams87 ciarams87 added the chore Pull requests for routine tasks label Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants