Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minimum k8s version to 1.19 #1855

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Update minimum k8s version to 1.19 #1855

merged 1 commit into from
Aug 17, 2021

Conversation

soneillf5
Copy link
Contributor

@soneillf5 soneillf5 commented Aug 13, 2021 •
edited
Loading

Proposed changes

Update the minimum k8s version to 1.19 and removing the redundant removing the flag -use-ingress-class-only argument

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@github-actions github-actions bot added enhancement Pull requests for new features/feature enhancements documentation Pull requests/issues for documentation labels Aug 13, 2021
pleshakov
pleshakov reviewed Aug 13, 2021
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soneillf5 since PR addresses two things - min version and -use-ingress-class-only argument, could we update the name and the description of it to include -use-ingress-class-only?

note that this /installation/running-multiple-ingress-controllers.md: doc also mentions -use-ingress-class-only argument

CHANGELOG.md Outdated Show resolved Hide resolved
cmd/nginx-ingress/main.go Outdated Show resolved Hide resolved
deployments/helm-chart/README.md Show resolved Hide resolved
@soneillf5 soneillf5 requested a review from pleshakov August 16, 2021 09:14
@soneillf5 soneillf5 force-pushed the feature/require-k8s-version-min-19 branch from 090f5ab to f7cfafe Compare August 16, 2021 10:32
@soneillf5 soneillf5 force-pushed the feature/require-k8s-version-min-19 branch from 20f19f5 to f2124a6 Compare August 17, 2021 09:51
@soneillf5 soneillf5 force-pushed the feature/require-k8s-version-min-19 branch from f2124a6 to c7ff8e5 Compare August 17, 2021 09:51
@soneillf5 soneillf5 merged commit 90a8611 into master Aug 17, 2021
@soneillf5 soneillf5 deleted the feature/require-k8s-version-min-19 branch August 17, 2021 11:17
@pleshakov pleshakov added the change Pull requests that introduce a change label Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@lucacome lucacome lucacome approved these changes

Assignees
No one assigned
Labels
change Pull requests that introduce a change documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soneillf5 @lucacome @pleshakov