Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pulling-ingress-controller-image.md #1824

Merged
merged 2 commits into from
Aug 10, 2021
Merged

Conversation

brianehlert
Copy link
Collaborator

Clarify that NIC subscription is required, not simply N+

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

Clarify that NIC subscription is required, not simply N+
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Aug 3, 2021
@pleshakov pleshakov enabled auto-merge (rebase) August 10, 2021 18:19
@pleshakov pleshakov disabled auto-merge August 10, 2021 18:19
@lucacome lucacome merged commit 4ce7ac1 into master Aug 10, 2021
@lucacome lucacome deleted the brianehlert-patch-3 branch August 10, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants