Create separate workflows for PRs and master in release-drafter #1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarams87
changed the title
vepatel
approved these changes
Jul 14, 2021
pleshakov
approved these changes
Jul 14, 2021
lucacome
approved these changes
Jul 14, 2021
| @@ -12,5 +9,7 @@ jobs: | |||
| runs-on: ubuntu-20.04 | |||
| steps: | |||
| - uses: release-drafter/release-drafter@v5 | |||
| with: | |||
| disable-releaser: true | |||
There was a problem hiding this comment.
Nice! How did you find it? It's not documented 😞
There was a problem hiding this comment.
I know, I had to go read the code! https://github.com/release-drafter/release-drafter/blob/master/action.yml#L46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
We are running into this issue: release-drafter/release-drafter#680 when we have "filter-by-commitish" and the PR "autolabeler" set. As far as I can tell, running the release-drafter on every PR creates a different draft release when we have "filter-by-commitish" set. This attempts to rectify by creating separate release drafter workflows so we can run the auto-labeller only on PRs. I think we can support releasing from release branches going forward by setting the 'commitish' to the name of the release branch - this should support patch releases.
Checklist
Before creating a PR, run through this checklist and mark each as complete.