Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add errorlint #1688

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Add errorlint #1688

merged 1 commit into from
Jun 23, 2021

Conversation

lucacome
Copy link
Member

Adding errorlint https://github.com/polyfloyd/go-errorlint

go-errorlint is a source code linter for Go software that can be used to find code that will cause problems with the error wrapping scheme introduced in Go 1.13.

@lucacome lucacome requested a review from a team June 21, 2021 22:36
@lucacome lucacome self-assigned this Jun 21, 2021
@lucacome lucacome requested review from ciarams87 and soneillf5 and removed request for a team June 21, 2021 22:36
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jun 21, 2021
@lucacome lucacome force-pushed the chore/more-linters branch from a2d4f9d to c43045f Compare June 22, 2021 01:02
@lucacome lucacome force-pushed the chore/add-errorlint branch from be1dce6 to eec49d1 Compare June 22, 2021 01:04
soneillf5
soneillf5 approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@soneillf5 soneillf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change, thanks!

@lucacome lucacome force-pushed the chore/more-linters branch from c43045f to c77b60e Compare June 22, 2021 20:11
Base automatically changed from chore/more-linters to master June 23, 2021 04:12
@lucacome lucacome force-pushed the chore/add-errorlint branch from eec49d1 to c0c32ad Compare June 23, 2021 04:13
@lucacome lucacome force-pushed the chore/add-errorlint branch from c0c32ad to a2375d2 Compare June 23, 2021 04:21
@lucacome lucacome merged commit 006e179 into master Jun 23, 2021
@lucacome lucacome deleted the chore/add-errorlint branch June 23, 2021 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soneillf5 soneillf5 soneillf5 approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

Assignees

@lucacome lucacome

Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucacome @ciarams87 @soneillf5