Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add app_protect_compressed_requests_action directive #1643

Merged
merged 2 commits into from
Jun 23, 2021
Merged

add app_protect_compressed_requests_action directive #1643

merged 2 commits into from
Jun 23, 2021

Conversation

galitskiy
Copy link
Contributor

@galitskiy galitskiy commented Jun 2, 2021 •
edited
Loading

Proposed changes

add support for app_protect_compressed_requests_action directive

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@netlify
Copy link

netlify bot commented Jun 2, 2021 •
edited
Loading

👷 Deploy request for nginx-kubernetes-ingress accepted.

🔨 Explore the source changes: b57e891c117b25506158c1a76c97f2c74a7ae55d

🔍 Inspect the deploy log: https://app.netlify.com/sites/nginx-kubernetes-ingress/deploys/60b7c9efaa4fcd0007835521

@pleshakov pleshakov self-requested a review June 4, 2021 23:33
pleshakov
pleshakov approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@galitskiy galitskiy force-pushed the ap-compressed-req-action branch from b57e891 to 9bda90b Compare June 9, 2021 15:28
@galitskiy galitskiy requested review from pleshakov and soneillf5 June 23, 2021 05:53
@galitskiy
Copy link
Contributor Author

Adding tests, please review again. Thank you

@vepatel vepatel requested a review from soneillf5 June 23, 2021 15:29
@pleshakov pleshakov merged commit 154ceef into nginx:master Jun 23, 2021
@galitskiy galitskiy deleted the ap-compressed-req-action branch June 24, 2021 01:51
@galitskiy galitskiy restored the ap-compressed-req-action branch June 24, 2021 01:52
@ciarams87 ciarams87 added the enhancement Pull requests for new features/feature enhancements label Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@soneillf5 soneillf5 soneillf5 approved these changes

Assignees
No one assigned
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@galitskiy @pleshakov @soneillf5 @ciarams87