Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature transportserver udp tests #1553

Merged
merged 1 commit into from
May 10, 2021
Merged

Feature transportserver udp tests #1553

merged 1 commit into from
May 10, 2021

Conversation

soneillf5
Copy link
Contributor

Proposed changes

This change adds tests for TransportServer UDP load balancing functionality.
It uses a test server to respond to UDP requests, allowing us to tests the number of replicas and endpoints that the TransportServer works with.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@soneillf5 soneillf5 requested review from vepatel and pleshakov April 26, 2021 14:27
@github-actions github-actions bot added documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements labels Apr 26, 2021
@soneillf5 soneillf5 force-pushed the feature-transportserver-udp-tests branch 2 times, most recently from 78a34f9 to d53933c Compare April 28, 2021 10:34
pleshakov
pleshakov reviewed Apr 28, 2021
View reviewed changes
tests/suite/test_transport_server_udp_load_balance.py Outdated Show resolved Hide resolved
tests/udp-server/main.go Outdated Show resolved Hide resolved
@soneillf5 soneillf5 force-pushed the feature-transportserver-udp-tests branch 3 times, most recently from 3c4e1cd to 28c0d0b Compare May 6, 2021 14:51
@pleshakov pleshakov self-requested a review May 6, 2021 17:53
@soneillf5 soneillf5 requested a review from pleshakov May 7, 2021 10:46
@soneillf5 soneillf5 force-pushed the feature-transportserver-udp-tests branch from 7d2ce87 to edeffc0 Compare May 10, 2021 08:46
@soneillf5 soneillf5 merged commit 504bad4 into master May 10, 2021
@lucacome lucacome deleted the feature-transportserver-udp-tests branch May 13, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@pleshakov pleshakov pleshakov approved these changes

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soneillf5 @pleshakov @vepatel