Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add load balancing method to TransportServer #1479

Merged
merged 1 commit into from
May 19, 2021
Merged

Add load balancing method to TransportServer #1479

merged 1 commit into from
May 19, 2021

Conversation

soneillf5
Copy link
Contributor

Proposed changes

This change allows a user to specify the load balancing method used by the TransportServer resource.

It changes the defaults to match the Nginx defaults of round robin.

It has different validation from the http load balancing method.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • [ x] I have read the CONTRIBUTING doc
  • [x ] I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • [ x] I have updated necessary documentation
  • [x ] I have rebased my branch onto master
  • [x ] I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Mar 23, 2021
ciarams87
ciarams87 approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@ciarams87 ciarams87 added the enhancement Pull requests for new features/feature enhancements label Mar 23, 2021
pleshakov
pleshakov suggested changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @soneillf5
Please see my feedback

pkg/apis/configuration/v1alpha1/types.go Show resolved Hide resolved
docs-web/configuration/transportserver-resource.md Show resolved Hide resolved
internal/configs/version2/nginx-plus.transportserver.tmpl Outdated Show resolved Hide resolved
pkg/apis/configuration/v1alpha1/types.go Show resolved Hide resolved
internal/configs/version2/nginx-plus.transportserver.tmpl Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/transportserver.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/transportserver.go Outdated Show resolved Hide resolved
@soneillf5 soneillf5 requested a review from pleshakov March 24, 2021 13:27
@soneillf5 soneillf5 force-pushed the feature-transportserver-loadbalance-method branch from 0bab691 to d9bd9aa Compare April 26, 2021 14:57
@soneillf5 soneillf5 force-pushed the feature-transportserver-loadbalance-method branch from d9bd9aa to b1212e9 Compare May 7, 2021 12:12
pleshakov
pleshakov reviewed May 10, 2021
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @soneillf5 Please see a few final comments. Otherwise, looks good

docs-web/configuration/transportserver-resource.md Show resolved Hide resolved
pkg/apis/configuration/validation/transportserver.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/transportserver_test.go Show resolved Hide resolved
pkg/apis/configuration/validation/transportserver_test.go Outdated Show resolved Hide resolved
deployments/helm-chart/crds/appprotect.f5.com_aplogconfs.yaml Outdated Show resolved Hide resolved
@soneillf5 soneillf5 force-pushed the feature-transportserver-loadbalance-method branch 2 times, most recently from 0370fb4 to bfe76d5 Compare May 11, 2021 16:33
pleshakov
pleshakov approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@soneillf5 soneillf5 force-pushed the feature-transportserver-loadbalance-method branch 5 times, most recently from 81517e4 to 5240654 Compare May 13, 2021 08:03
@soneillf5 soneillf5 force-pushed the feature-transportserver-loadbalance-method branch from 5240654 to be34f86 Compare May 19, 2021 14:18
@soneillf5 soneillf5 force-pushed the feature-transportserver-loadbalance-method branch from be34f86 to 61c5b76 Compare May 19, 2021 15:40
@soneillf5 soneillf5 merged commit c876d19 into master May 19, 2021
@lucacome lucacome deleted the feature-transportserver-loadbalance-method branch May 25, 2021 20:24
@pleshakov pleshakov changed the title Add load balancing method to transport server config Add load balancing method to TransportServer Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciarams87 ciarams87 ciarams87 approved these changes

@pleshakov pleshakov pleshakov approved these changes

@lucacome lucacome Awaiting requested review from lucacome

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soneillf5 @pleshakov @ciarams87