Support IngressClassName in TransportServer #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleshakov
added
enhancement
soneillf5
suggested changes
Mar 3, 2021
soneillf5
approved these changes
Mar 4, 2021
lucacome
approved these changes
Mar 4, 2021
Co-authored-by: Luca Comellini <[email protected]>
|
@pleshakov Is there an estimate of when this change will be included in a release? |
|
Hi @pstackle it will go into 1.11.0, scheduled for the end of march |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The TransportServer resource now includes the
spec.ingressClassName, which users can set to choose which NGINX Ingress Controller they want to handle their TransportServer resources. This is useful when multiple NGINX Ingress Controllers are running in the cluster (for example, one for prod and one for dev).