Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configmap tests. Fix Helm chart pipeline #1376

Merged
merged 3 commits into from
Feb 15, 2021

Conversation

Dean-Coakley
Copy link
Contributor

@Dean-Coakley Dean-Coakley commented Feb 12, 2021

Proposed changes

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley self-assigned this Feb 12, 2021
@github-actions github-actions bot added the chore Pull requests for routine tasks label Feb 12, 2021
@Dean-Coakley Dean-Coakley requested review from lucacome and removed request for mikestephen February 12, 2021 15:38
@Dean-Coakley Dean-Coakley force-pushed the chore/fix-cfgmTests-fix-helmPipeline branch from ab170b0 to f434728 Compare February 12, 2021 20:06
Dean-Coakley and others added 3 commits February 15, 2021 12:05
version metadata is now a valid semver so this sed is no longer required
Co-authored-by: Venktesh Shivam Patel <[email protected]>
@Dean-Coakley Dean-Coakley force-pushed the chore/fix-cfgmTests-fix-helmPipeline branch from 8ed5b82 to 9823281 Compare February 15, 2021 12:07
@Dean-Coakley Dean-Coakley merged commit 1832385 into master Feb 15, 2021
@Dean-Coakley Dean-Coakley deleted the chore/fix-cfgmTests-fix-helmPipeline branch February 15, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants