Replace deprecated imagePullSecrets helm setting #1232
Merged
+9
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In order to be listed in the Rancher App Catalog we need to be able to set
imagePullSecrets
so that deployments created by Rancher can pull from private docker registries.However, Rancher only support the following datatypes:
string
,multiline
,boolean
,int
,enum
,password
,storageclass
,hostname
,pvc
,secret
.This does not allow to specify a string array as required. This PR changes to accept one string instead of an array. This doesn't affect any known use cases of this field.
Checklist
Before creating a PR, run through this checklist and mark each as complete.