Add pod_owner label to metrics when -spire-agent-address is set #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
NGINX Service Mesh needs to know the owner kind and name of the pod in order to produce metrics according to the smi-spec. This PR adds a
pod_ownerlabel to metrics when the-spire-agent-addressis set. The metrics produced by the mesh only support owner types of Deployment, StatefulSet, and DaemonSet. If the owner type is not one of these resources we default to deployment.Checklist
Before creating a PR, run through this checklist and mark each as complete.