-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support real-ip in default server #1129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is some weird indentation/alignment appearing in the files changed tab but locally they look fine, could someone check it out just to be sure
@LorcanMcVeigh Indentation looks strange because it has a mix of tabs and spaces. I believe this happened because you copied the config from https://github.com/nginxinc/kubernetes-ingress/blob/master/internal/configs/version1/nginx.ingress.tmpl which uses tabs, into a file that uses spaces. You should be able to just delete all the white space and recreate with your editor to resolve it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
You can add Fixes: https://github.com/nginxinc/kubernetes-ingress/issues/1072
to the PR description to autoclose that issue upon merge if you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Proposed changes
Support
real-ip-header
,real-ip-recursive
andset-real-ip-from
in the default serverFixes: #1072
Checklist
Before creating a PR, run through this checklist and mark each as complete.