Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RateLimit policy support #1120

Merged
merged 5 commits into from
Sep 3, 2020
Merged

Add RateLimit policy support #1120

merged 5 commits into from
Sep 3, 2020

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

  • Add rateLimit policy
    • Emit events and add warning resource status when multiple different limit request options are set in the same context. 1 per difference.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley added the enhancement Pull requests for new features/feature enhancements label Aug 31, 2020
@Dean-Coakley Dean-Coakley self-assigned this Aug 31, 2020
pleshakov
pleshakov suggested changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Dean-Coakley

There are a few small problems. Otherwise, looks good!!

docs-web/configuration/policy-resource.md Outdated Show resolved Hide resolved
docs-web/configuration/policy-resource.md Outdated Show resolved Hide resolved
examples-of-custom-resources/rate-limit/README.md Outdated Show resolved Hide resolved
docs-web/configuration/policy-resource.md Outdated Show resolved Hide resolved
internal/configs/virtualserver_test.go Show resolved Hide resolved
jputrino
jputrino approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@jputrino jputrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a few comments/suggestions.

pleshakov
pleshakov approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Dean-Coakley Dean-Coakley merged commit a6cbea6 into master Sep 3, 2020
@Dean-Coakley Dean-Coakley deleted the add-rate-limit-policy branch September 3, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jputrino jputrino jputrino approved these changes

@pleshakov pleshakov pleshakov approved these changes

@lucacome lucacome lucacome approved these changes

Assignees

@Dean-Coakley Dean-Coakley

Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dean-Coakley @lucacome @pleshakov @jputrino