Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing threat campaigns key to crd #1110

Merged
merged 1 commit into from
Aug 28, 2020
Merged

add missing threat campaigns key to crd #1110

merged 1 commit into from
Aug 28, 2020

Conversation

rafwegv
Copy link
Contributor

@rafwegv rafwegv commented Aug 25, 2020

Proposed changes

Addition of threat-campaigns element to crd, which may be used to disable particular TC.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@rafwegv rafwegv added the bug An issue reporting a potential bug label Aug 25, 2020
@rafwegv rafwegv self-assigned this Aug 25, 2020
pleshakov
pleshakov approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rafwegv rafwegv merged commit b3a54d7 into master Aug 28, 2020
@rafwegv rafwegv deleted the ap-extref-patch branch August 28, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@pleshakov pleshakov pleshakov approved these changes

Assignees

@rafwegv rafwegv

Labels
bug An issue reporting a potential bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafwegv @pleshakov @Dean-Coakley