Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for access-control using policies in vs and vsr #1101

Merged
merged 3 commits into from
Aug 19, 2020
Merged

Add tests for access-control using policies in vs and vsr #1101

merged 3 commits into from
Aug 19, 2020

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Aug 18, 2020

Proposed changes

  • Add vsr sub-route policy tests.
  • Add tests to check if vsr sub-route policies override vs spec and route policies.
  • Refactoring.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

pleshakov
pleshakov approved these changes Aug 18, 2020
View reviewed changes
tests/suite/test_ac_policies_vsr.py Outdated Show resolved Hide resolved
@vepatel vepatel merged commit aa6e36e into master Aug 19, 2020
@vepatel vepatel deleted the vs-vsr-policies-test branch August 19, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@pleshakov pleshakov pleshakov approved these changes

@lucacome lucacome Awaiting requested review from lucacome

@LorcanMcVeigh LorcanMcVeigh Awaiting requested review from LorcanMcVeigh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vepatel @pleshakov @Dean-Coakley